fix: follow-up to PR #234 (remove accidental file, revert from document.write to equiv. srcdoc) - #248
Merged
Merged
Conversation
Follow-up to PR #234. This file was accidentally included.
@modelcontextprotocol/ext-apps
@modelcontextprotocol/server-basic-react
@modelcontextprotocol/server-basic-vanillajs
@modelcontextprotocol/server-budget-allocator
@modelcontextprotocol/server-cohort-heatmap
@modelcontextprotocol/server-customer-segmentation
@modelcontextprotocol/server-scenario-modeler
@modelcontextprotocol/server-system-monitor
@modelcontextprotocol/server-threejs
@modelcontextprotocol/server-wiki-explorer
commit: |
ochafik
marked this pull request as draft
January 12, 2026 22:01
Follow-up to PR #234 per domfarolino's review feedback.
ochafik
force-pushed
the
ochafik/pr234-followup
branch
from
January 12, 2026 22:12
af8045c to
a44fba6
Compare
ochafik
changed the title
ochafik
changed the title
ochafik
marked this pull request as ready for review
January 12, 2026 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up changes from review comments on #234:
Changes
Remove
tamper-detection.ts- This file was accidentally included and wasn't meant to be submitted (comment)Revert to srcdoc in
sandbox.ts- the comment and change aboutdocument.writewas a mix of hallucination and superstition (what it purported to fix - the new Map example - was actually fixed by other changes - worker-src and the likes).cc @domfarolino